----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104858/#review14238 -----------------------------------------------------------
Ship it! Ship It! - Maks Orlovich On May 21, 2012, 12:42 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104858/ > ----------------------------------------------------------- > > (Updated May 21, 2012, 12:42 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Fix parseFloat not cutting-off leading unicode spaces > > parseInt cuts away the leading spaces, like it should, but we don't to it for > parseFloat, like we should. > UString::toDouble does remove leading spaces, but only ascii spaces, no > unicodespaces. > > ECMA 15.1.2.3 Step 2 confirms that leading spaces should be cut > > depends on https://git.reviewboard.kde.org/r/104855/ > > > Diffs > ----- > > kjs/ustring.cpp 136efb5 > > Diff: http://git.reviewboard.kde.org/r/104858/diff/ > > > Testing > ------- > > Fixes a couple of ecma parseFloat tests > > > Thanks, > > Bernd Buschinski > >
