----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105364/ -----------------------------------------------------------
(Updated June 29, 2012, 4:22 p.m.) Review request for kdelibs. Changes ------- It is not possible to fix the memory leak in void KAction::setAuthAction(const QString &actionName) the way I tried. kdelibs will have it until frameworks is ready. Therefore, replace the delete by just two comments. Description ------- the action created locally in void KAction::setAuthAction(const QString &actionName) is deleted. The others must be handled by the callers of void KAction::setAuthAction(KAuth::Action *action). Diffs (updated) ----- kdeui/actions/kaction.cpp 0f6343c Diff: http://git.reviewboard.kde.org/r/105364/diff/ Testing ------- working with it this afternoon. Thanks, Jaime Torres Amate
