----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105399/#review15287 -----------------------------------------------------------
Ship it! Looks good (except for the new trailing whitespaces, see the red boxes on reviewboard) - David Faure On July 1, 2012, 9:11 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105399/ > ----------------------------------------------------------- > > (Updated July 1, 2012, 9:11 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > If we add xmlclients to ktoolbar when plugging them in we should remove them > when unplugging them > > > This addresses bug 296622. > http://bugs.kde.org/show_bug.cgi?id=296622 > > > Diffs > ----- > > kdeui/widgets/ktoolbar.h c78263f > kdeui/widgets/ktoolbar.cpp c6bd200 > kdeui/xmlgui/kxmlguifactory_p.cpp 083ddf5 > > Diff: http://git.reviewboard.kde.org/r/105399/diff/ > > > Testing > ------- > > The crash is gone as described in the steps in the bug to reproduce > > > Thanks, > > Albert Astals Cid > >