----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105388/#review15460 -----------------------------------------------------------
Ship it! Ship It! - Maks Orlovich On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105388/ > ----------------------------------------------------------- > > (Updated June 29, 2012, 6:06 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Range needs a prototype > > some websites do stuff like > > if (Range.prototype.someFunction !== undefined) > { > Range.prototype.someFunction = ourOwnFunction; > } > > the problem is we report no prototype, and thus we have > Range -> undefined.someFunction > which will always fail and throw an exception. > > But Range should have a prototype, so this patch adds its valid prototype and > makes some websites happy. > > > Diffs > ----- > > khtml/ecma/kjs_range.cpp 500ebbd > > Diff: http://git.reviewboard.kde.org/r/105388/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Buschinski > >
