----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/#review15461 -----------------------------------------------------------
Ship it! kjs/array_object.cpp <http://git.reviewboard.kde.org/r/105391/#comment12090> I was thinking you could get rid of the if (element->isObject()) conditional as well. - Maks Orlovich On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105391/ > ----------------------------------------------------------- > > (Updated July 4, 2012, 10:27 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: Use toPrimitive in Array.join to get the correct String > > the default value case for String is present here, as testcase > S15.4.4.5_A3.2_T2 shows > > > Diffs > ----- > > kjs/array_object.cpp 0da29b0 > > Diff: http://git.reviewboard.kde.org/r/105391/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Buschinski > >
