----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105805/#review16818 -----------------------------------------------------------
Ship it! Ship It! - David Faure On July 31, 2012, 3:52 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105805/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 3:52 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > This patch is partially a code clean up and partially a fix. It addresses the > issue of the security icon being clipped on secure sites where the favorite > icon is missing from the address bar as shown in the first screenshot below. > For some reason, instead of simply making space for the secuirty icon, the > current code unnecessarily attempts to take the size of the favorite icon > into consideration. The second and third screenshots of the address bar, > taken after the patch was applied, show that doing so was unnecessary. > > > Diffs > ----- > > konqueror/src/konqcombo.cpp cdf840a > > Diff: http://git.reviewboard.kde.org/r/105805/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > address bar without fix > http://git.reviewboard.kde.org/r/105805/s/657/ > address bar with fix > http://git.reviewboard.kde.org/r/105805/s/658/ > address bar with fix & favicon > http://git.reviewboard.kde.org/r/105805/s/659/ > > > Thanks, > > Dawit Alemayehu > >
