----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106052/#review17528 -----------------------------------------------------------
I think the right thing to do is to fix bug 206500, and then apply this patch, rather than come up with yet another feedback mechanism. Let's make warning() actually work, and let's make sure it's not emitted erroneously. I'll look into fixing bug 206500 as soon as possible (let's say beginning of next week). kdeui/jobs/kdialogjobuidelegate.cpp <http://git.reviewboard.kde.org/r/106052/#comment13720> No space after the method name (this usually happens when copy/pasting from the Qt documentation :-) In fact, no space within the parenthesis either, but you couldn't guess that: existing code doesn't follow the kdelibs coding style. When writing new code, no spaces within (...). kio/kio/job.cpp <http://git.reviewboard.kde.org/r/106052/#comment13721> Left -> Let. How did this come in? It wasn't in my initial patch :) - David Faure On Aug. 16, 2012, 12:18 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106052/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 12:18 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > Display a warning when CopyJob fails to enter a subdirectory and thus can't > copy it's content. > > > Diffs > ----- > > kdeui/jobs/kdialogjobuidelegate.cpp fe48f87 > kio/kio/copyjob.h eb88c7a > kio/kio/copyjob.cpp 8dde763 > kio/kio/job.cpp a7e1baf > kio/kio/jobclasses.h de27f40 > > Diff: http://git.reviewboard.kde.org/r/106052/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vratil > >
