----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106096/#review17756 -----------------------------------------------------------
"some file with#anchor" < is this an HTML anchor, or a filename with a hash? The real test for your change is the case of completing a remote file (e.g. sftp, fish, etc.) that contains a '#' in the filename. If you're skipping percent encoding for the '#', it will be parsed as an anchor, by the user of that URL, i.e. the filename will be incomplete. If you hit such a bug, the solution is to use the KUrl API better (e.g. addPath and then prettyUrl), so that only the necessary characters get escaped, rather than all of them, indeed. - David Faure On Aug. 20, 2012, 1:51 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106096/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2012, 1:51 p.m.) > > > Review request for kdelibs, David Faure and Thiago Macieira. > > > Description > ------- > > when using konqueror and typing "man:" it starts to list possible entries > which the kio_man slave generates. > However, konqueror displays percent encoded URLs, e.g. "man:%281%29/" instead > of "man:(1)/", which is not human readable. > Also, there is some inconsistency in what konqueror shows in its completion > list. > E.g. when typing "man:mklos" it shows "man:mklost%2Bfound" in the completion > list, > but when I select this entry, the URL in the address line edit is changed and > displays as > "man:mklost+found" > Even worse: when I now again type "man:mklos", I get 2 entries in the > completion list > "man:mklost%2Bfound" and "man:mklost+found" (the one coming from the > completion, the other from the history) > No matter which one I chose, the result in the address line edit is always > the unencoded one, which - for a user - makes much more sense. > > This patch removes the calls to make the matches percent encoded. > Why would I ever want to get a percent encoded string from a completer, which > is about helping a human ? > > > Diffs > ----- > > kio/kio/kurlcompletion.cpp 269fdc1 > > Diff: http://git.reviewboard.kde.org/r/106096/diff/ > > > Testing > ------- > > man:, fish:, local dir /tmp and checking the completion in konqueror when > using a dir e.g. named "some ö ä ü umlauts", "some file with#anchor" > > > Thanks, > > Martin Koller > >
