----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18055 -----------------------------------------------------------
I've looked over everything and didn't see anything I didn't like. I'd like to apply and and compile and run what little test cases do exist, but git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake don't exist yet. Are those from stray commits on your end or is there an earlier review request that includes them? I'm trying to apply to KDE/4.10 as this is not strictly a bugfix, though I didn't see either of those in KDE/4.9 or frameworks branches either. - Michael Pyne On Aug. 26, 2012, 5:15 p.m., Vadim Zhukov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106174/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 5:15 p.m.) > > > Review request for kdelibs and Michael Pyne. > > > Description > ------- > > This patch does move some run-time checks (mainly for different locking > mechanisms) in KSharedDataCache to build time (CMake). > > > This addresses bug 305023. > http://bugs.kde.org/show_bug.cgi?id=305023 > > > Diffs > ----- > > kdecore/util/config-util.h.cmake 83ccdf7 > kdecore/util/kshareddatacache.cpp 393902e > kdecore/util/kshareddatacache_p.h ec5a7a0 > kdecore/util/ConfigureChecks.cmake fe9f47e > > Diff: http://git.reviewboard.kde.org/r/106174/diff/ > > > Testing > ------- > > On OpenBSD-CURRENT. > > > Thanks, > > Vadim Zhukov > >