----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18384 -----------------------------------------------------------
First of all, thanks for the patch! I was not aware of any "constant breakage of the Konqueror directory filtering plugin once Konqueror was switched to use Dolphin's part for filemanagement", and I think neither was Peter. I checked it now, and can confirm that mime type filtering does not work (to be honest, I never noticed this menu entry in Konqueror before), but did this actually ever work in the DolphinPart? A quick look at the DolphinView code from KDE 4.7 didn't show me anything that filters mime types. What else is broken about the filtering functionality at the moment? Filtering using ~/*.jpg in Konqueror's location bar works for me. Moreover, what are the new signals itemsAdded() and itemsDeleted() needed for? They could be confused easily with the existing signals itemsInserted() and itemsRemoved(). Therefore, I think we should not add these new signals unless there is a *very* good reason to have them. - Frank Reininghaus On Aug. 31, 2012, 7:30 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106289/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 7:30 p.m.) > > > Review request for Dolphin and KDE Base Apps. > > > Description > ------- > > The attached patch provides an implementation of KParts' > ListingFilterExtension for Dolphin. The extension allows the Dolphin KPart to > provide directory/file filtering services without requiring direct linking > against Dolphin itself. > > The review for the new KPart listing filter extension > (ListingFilterExtension) can be found at > https://git.reviewboard.kde.org/r/106288/ > > > Diffs > ----- > > dolphin/src/dolphinpart.h e5693b3 > dolphin/src/dolphinpart.cpp fff7dc0 > dolphin/src/kitemviews/kfileitemmodel.h d9bebdf > dolphin/src/kitemviews/kfileitemmodel.cpp 6936af4 > dolphin/src/kitemviews/private/kfileitemmodelfilter.h 9bdf1fd > dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp 816d356 > dolphin/src/views/dolphinview.h 10f63c5 > dolphin/src/views/dolphinview.cpp 8050415 > > Diff: http://git.reviewboard.kde.org/r/106289/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
