-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106524/
-----------------------------------------------------------
Review request for KDE Runtime.
Description
-------
The referenced bug suggests that it should be possible to individually select
screen savers that are to be considered when the "Random" option is chosen.
This patch implements that.
In order to avoid having to duplicate the complete saver tree view (and the
code to generate it) within the random saver's setup mode, check boxes are
added to the kcontrol saver list (with the exception of the random saver
itself). The state of these is saved to the random saver's config file. This
selection is in addition to the two options within the saver's setup dialogue,
so if for example "Use OpenGL screen savers" is not checked than any OpenGL
savers will be ignored even if their boxes are checked in the tree view.
(Submitting to kde-runtime, there is no kde-workspace group)
This addresses bug 57572.
http://bugs.kde.org/show_bug.cgi?id=57572
Diffs
-----
kcontrol/screensaver/scrnsave.h 7c8deba
kcontrol/screensaver/scrnsave.cpp c0507d4
kscreensaver/krandom_screensaver/random.cpp 4047184
Diff: http://git.reviewboard.kde.org/r/106524/diff/
Testing
-------
Built saver and kcontrol module with these changes. Checked operation of
kcontrol module, saving of settings in the config file and operation of the
random saver.
Screenshots
-----------
kcmshell4 screensaver
http://git.reviewboard.kde.org/r/106524/s/733/
Thanks,
Jonathan Marten
