----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19523 -----------------------------------------------------------
Why did the original code fail? It already checks for rootIsToolbarGroup(), which should be true in the case you describe, right? So the saving was supposed to be skipped then... - David Faure On Sept. 25, 2012, 11:01 a.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106563/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 11:01 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > Currently, an empty tbcache file is created when the toolbar bookmarks are > the full bookmarks, i.e. no entries/folders with toolbar attribute. > > > Diffs > ----- > > kio/bookmarks/kbookmarkmanager.cc d8a9cb7 > > Diff: http://git.reviewboard.kde.org/r/106563/diff/ > > > Testing > ------- > > > Thanks, > > Stefan Brüns > >
