> On Sept. 30, 2012, 12:23 a.m., Alex Fiestas wrote: > > I decided to make a review because I wonder why we were using description > > before, was it working better with HAL?
Nope, but the HAL backend itself used to have a very similar piece of code. It's probably a better idea to have that code in the udisk* backends than in KFilePlacesModel. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106653/#review19613 ----------------------------------------------------------- On Sept. 30, 2012, 12:22 a.m., Alex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106653/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2012, 12:22 a.m.) > > > Review request for kdelibs and Kevin Ottens. > > > Description > ------- > > The description is useful for when the device is not hotpluggable/removeable, > for example to show: > 96.3 GiB Hard Drive > 15.1 GiB Hard Drive > > instead of two identical labels. > > But when it comes to removable/hotpluggable we want to show the Product to be > able to show: > > Nokia N9 > Nexus 7 > > Instead of > Portable Media Player > Portable Media Player > > Screenshots from this review are applicable: > https://git.reviewboard.kde.org/r/106637/ > > > Diffs > ----- > > kfile/kfileplacesitem.cpp 3ada0c3 > > Diff: http://git.reviewboard.kde.org/r/106653/diff/ > > > Testing > ------- > > > Thanks, > > Alex Fiestas > >
