----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/2690/#review10970 -----------------------------------------------------------
I also disagree with the patch. Syncing a file system is expensive and degrades performance. Also, latest KDE releases have an implicit "please wait, I'm writing your data to your disk" warning via a spinning disk in USB notifier. Also dolphin doesn't change its mounted icon until sync completes. These changes makes the patch useless regardless of the overhead, performance degradation and media damage (which is a regression) it introduces. Last but not the least, continuously syncing voids the kernel's transfer optimizations and confuses it. - Hakan Bayindir On Jan. 23, 2010, 2:23 p.m., Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/2690/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2010, 2:23 p.m.) > > > Review request for kdelibs, Kevin Ottens and David Faure. > > > Description > ------- > > This simple patch allows file copy to external devices to be synchronous. > This patch assumes that external devices are mounted on a subdirectory of > /media/. If /media/ is not used this patch will not work so everything will > be as before. > For more dettails see also https://bugs.kde.org/show_bug.cgi?id=195044. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1077183 > > Diff: http://svn.reviewboard.kde.org/r/2690/diff/ > > > Testing > ------- > > This patch is recent, so I'm testing it right now. kio-file is a critical > component so I will do more tests. > > Checking for file corruption might be a good idea: > dd if=/dev/full of=testFile count=numOfBlocks > md5sum testFile > Copy it, umount, mount and check the md5sum. > > > Thanks, > > Davide Bettio > >
