----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20065 -----------------------------------------------------------
konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15891> Did you change this if() wrongly? Now the code says "if I could find the dialog-warning icon, then ignore it and ask QStyle instead". This makes no sense ;) konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15890> All this generic code could be simplified for the use case at hand. Maybe after inserting a '\n' in the string (between the two sentences), and then all that squeezing and wrapping can be removed. Let's keep this simple and maintainable. konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15889> This line and the one below, can be removed now. They don't do anything. konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15892> The label is two lines at most, it will never be bigger than a third of the desktop height. Remove usingScrollArea and the associated code. The tree widget can be tall, yes, but not the label on top. - David Faure On Oct. 4, 2012, 3:50 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106503/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2012, 3:50 a.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch fixes one of those pet peeve bugs that infurate me from > time to time by allowing me to unselect the sessions I do not want to be > restored when Konqueror's restore session dialog pops up. > > > This addresses bug 260282. > http://bugs.kde.org/show_bug.cgi?id=260282 > > > Diffs > ----- > > konqueror/src/konqsessionmanager.h ee629e4 > konqueror/src/konqsessionmanager.cpp 68a003f > > Diff: http://git.reviewboard.kde.org/r/106503/diff/ > > > Testing > ------- > > * Unselected sessions should not be restored. > * If all available sessions are selected (the default), the behavior should > remain the same as it is today. > * If all available sessions are unselected, disable the "Restore Session" > button. > > > Screenshots > ----------- > > old restore dialog > http://git.reviewboard.kde.org/r/106503/s/729/ > new restore dialog > http://git.reviewboard.kde.org/r/106503/s/731/ > new restore dialog v2 > http://git.reviewboard.kde.org/r/106503/s/739/ > new restore dialog v3 > http://git.reviewboard.kde.org/r/106503/s/750/ > > > Thanks, > > Dawit Alemayehu > >
