----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106909/ -----------------------------------------------------------
Review request for KDE Runtime. Description ------- Hi, this patch fixes an issue where kio_smb wouldnt save the credentials in kwallet wether one checks the "save password" box or not. In slavebase.h is the following is stated: "Starting with KDE 4.7, calling openPasswordDialog will no longer store passwords automatically for you. This was done to avoid accidental storage of incorrect or invalid password information." So i added a call to cacheAuthentication() to store the password permanently. Diffs ----- kioslave/smb/kio_smb_auth.cpp 1010ffc Diff: http://git.reviewboard.kde.org/r/106909/diff/ Testing ------- Used dolphin to access a samba share and checked the "save password" dialog. Verified that the password gets stored in KWallet. Thanks, Gordian Klein
