----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107421/#review22391 -----------------------------------------------------------
This probably needs a #ifdef on the kdelibs version number, then, since apparently kde-baseapps master only requires kdelibs-4.8... It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, but that wouldn't help anyway. - David Faure On Nov. 22, 2012, 5:26 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107421/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2012, 5:26 p.m.) > > > Review request for KDE Base Apps, David Faure and Frank Reininghaus. > > > Description > ------- > > The attached patch ports Dolphin away from using KIO::SlaveConfig::configData > into the newly added KProtocolManager::charsetFor API. KIO::SlaveConfig was > never intended to be a public class and as such it is going to go away in KF5. > > Please note that you need to latest kdelibs from the 4.10 branch in order to > compile this change. > > > Diffs > ----- > > dolphin/src/views/dolphinremoteencoding.cpp 375b3fd > > Diff: http://git.reviewboard.kde.org/r/107421/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
