----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/#review23728 -----------------------------------------------------------
This review has been submitted with commit e7c32d888a4cc62bfc00b698349b710b32576db1 by Sebastian Gottfried to branch KDE/4.9. - Commit Hook On Dec. 19, 2012, 2:35 p.m., Sebastian Gottfried wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107813/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 2:35 p.m.) > > > Review request for KDE Runtime and Marco Martin. > > > Description > ------- > > There is a bug in the tool button and button components resulting in layout > breakage if one clears and sets the text property of the component when not > visible, see the attached screenshot. > > I have tried to solve the issue without changing the existing anchoring > system, but without success. The only working solution was to put the icon > and the label item into Row item. That way I was able to fix the bug and even > get rid of the ugly explicit non-declarative anchor assignments. > > I have also removed the preferredWidth property of the label item, that one > always evaluated to paintedWidth, anyway. > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/Button.qml 5bfb8d7 > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 594067d > > Diff: http://git.reviewboard.kde.org/r/107813/diff/ > > > Testing > ------- > > Work as expected. No behavioral changes apart from the bugfix. > > > Screenshots > ----------- > > Broken tool button layout > http://git.reviewboard.kde.org/r/107813/s/921/ > > > Thanks, > > Sebastian Gottfried > >
