----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review23979 -----------------------------------------------------------
staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/107412/#comment18263> This tr() call needs to use the same context as the strings. The context is the class name by default, so SomeNamespace::Loader, this doesn't match what you used in the array. Probably better to pass the context explicitely than to try and guess it though: QCoreApplication::translate("SonnetDictionaryLoader", variantEnglish, "dictionary variant") - David Faure On Dec. 24, 2012, 10:03 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107412/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2012, 10:03 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > port sonnet away from i18nc. > > > Diffs > ----- > > staging/sonnet/src/core/loader.cpp 887aee5 > staging/sonnet/src/core/settings.cpp 59cb593 > staging/sonnet/src/core/speller.cpp f831f55 > > Diff: http://git.reviewboard.kde.org/r/107412/diff/ > > > Testing > ------- > > it builds. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
