----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108057/#review24355 -----------------------------------------------------------
Ship it! Why 3 separate descriptions for Chrome ? Wouldn't the last 2 just like the other ones suffice ? Anyways, it would be nice if we could simply remove all the old and unsupported user-agent strings. Perhaps we should do that for 4.10.1. - Dawit Alemayehu On Dec. 31, 2012, 10:25 p.m., Guillaume de Bure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108057/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2012, 10:25 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > I find that the current list of Browser identities that you can use in > konqueror or rekonq is so very obsolete... I used information from > http://www.useragentstring.com/pages/Browserlist/ and wrote some additional > .desktop files, specifically: > * Chrome 22, 23, 24 > * Firefox 15, 16 > * IE 8, 9 > * Opera 11, 12 > * Safari 5, 6 > > I purposely did not update the CMakeLists.txt yet, waiting for some initial > feedback first. I also intend to remove some other entries from the current > file list, unsure whether that should come in a separate review request > > > Diffs > ----- > > konqueror/settings/kio/uasproviders/chrome22oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/chrome23oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/chrome24oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/firefox15oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/firefox16oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/ie80onwinnt60.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/op1162oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/op1202oncurrent.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/safari517.desktop PRE-CREATION > konqueror/settings/kio/uasproviders/safari60.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/108057/diff/ > > > Testing > ------- > > > Thanks, > > Guillaume de Bure > >
