----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/#review24415 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Dec. 30, 2012, 1:37 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107048/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2012, 1:37 a.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch is an attempt to fix the bug where opening certain types > of documents in a background tab results in the new tab being activated > inadvertently. > > The issue can be reproduced by simply attempting to open a PDF document using > either the MMB or the CTRL+LMB button in Konqueror. If you have a local PDF > file simply navigate to the location of the file and click on it using the > MMB. Otherwise, see the aforementioned bug report for a site with PDF links > in it. If the "Open new tabs in background" option is checked when you > clicked on the PDF document, then the PDF document is opened embedded in > Konqueror tab in the background. However, this background tab should not be > activated when the aforementioned option is enabled. > > Unfortunately, in the currently implementation the background tab will get > activated if the part used to handle the resource (PDF file in this case) > issues a FocusIn event, for example by calling setFocus. That is because > KPart::PartManager installs an event filter on all the KParts it manages, > listens for FocusIn events, and invokes KParts::PartManager::setActivatePart. > > > This addresses bug 306417. > http://bugs.kde.org/show_bug.cgi?id=306417 > > > Diffs > ----- > > konqueror/src/konqmainwindow.cpp 630dd46 > konqueror/src/konqviewmanager.cpp 948a2a9 > > Diff: http://git.reviewboard.kde.org/r/107048/diff/ > > > Testing > ------- > > - Tested opening a PDF file when the "Open new tabs in background" option is > checked. > - Tested opening a PDF file when the "Open new tabs in background" option is > UNchecked. > - Tested opening a PDF link from a webpage using both the MMB and CTRL+LMB. > > > Thanks, > > Dawit Alemayehu > >
