----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107775/#review24505 -----------------------------------------------------------
Ship it! drkonqi/drkonqidialog.cpp <http://git.reviewboard.kde.org/r/107775/#comment18814> I am slightly worried about "<date> <time>" being in this fixed order and without any proper context for the translators. I'd at least put some context about %5 and %6 in the context comment ("@info"). Apart from that, everything else is fine. - George Kiagiadakis On Dec. 17, 2012, 11 a.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107775/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2012, 11 a.m.) > > > Review request for KDE Runtime and George Kiagiadakis. > > > Description > ------- > > This patch introduces two changes: > > 1. show the crash time in the bottom of the "General" tab > 2. use the remembered crash time instead of the current time as part of the > suggested file name when saving the backtrace . > > > This addresses bug 309330. > http://bugs.kde.org/show_bug.cgi?id=309330 > > > Diffs > ----- > > drkonqi/crashedapplication.h 403457d > drkonqi/crashedapplication.cpp 67ca58e > drkonqi/drkonqi.cpp e1d6222 > drkonqi/drkonqibackends.cpp 59f3b35 > drkonqi/drkonqidialog.cpp 141679b > > Diff: http://git.reviewboard.kde.org/r/107775/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > show crash in "General" tab > http://git.reviewboard.kde.org/r/107775/s/905/ > > > Thanks, > > Jekyll Wu > >
