> On Jan. 7, 2013, 6:38 p.m., Jeremy Paul Whiting wrote: > > Looks good to me, I wonder why you changed the suffix bits the way you did, > > why not just make it initialized in the BackgroundFinder constructor and > > use m_suffixes directly instead of calling suffixes() itself?
Ah nevermind I see you call it in image.cpp also. Ok, it looks good I'll push it to master branch (so it will make it into KDE SC 4.11) mind if I put your e-mail address in the commit message? - Jeremy Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24937 ----------------------------------------------------------- On Dec. 21, 2012, 5:11 p.m., Erwan MATHIEU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107821/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2012, 5:11 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > Patch which corrects bug 235710 : Plasma Wallpaper Slideshow to periodially > recheck contents of image folder > > > This addresses bug 235710. > http://bugs.kde.org/show_bug.cgi?id=235710 > > > Diffs > ----- > > plasma/generic/wallpapers/image/backgroundlistmodel.h a289f49 > plasma/generic/wallpapers/image/backgroundlistmodel.cpp f5a4dce > plasma/generic/wallpapers/image/image.h 417f5a7 > plasma/generic/wallpapers/image/image.cpp 006a748 > > Diff: http://git.reviewboard.kde.org/r/107821/diff/ > > > Testing > ------- > > Many pictures in many folders with many subfolders, adding and removing files > (sometimes no more files available) > > > Thanks, > > Erwan MATHIEU > >
