> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > <http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183> > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining if a language is CJK? > > Christoph Feck wrote: > "CJK" is actually naming the languages which use CJK, so the list is > hardcoded by definition.
I guess the question is not "which languages are CJK" but "which languages have this problem". - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25038 ----------------------------------------------------------- On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108285/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 4:33 a.m.) > > > Review request for kde-workspace. > > > Description > ------- > > CJK languages do not use space as words seperator. > > And a CJK translation of the text in Systemsettings are very short. A single > line is enough for them. > > > This addresses bug 234407. > http://bugs.kde.org/show_bug.cgi?id=234407 > > > Diffs > ----- > > systemsettings/icons/IconMode.cpp 37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e > > Diff: http://git.reviewboard.kde.org/r/108285/diff/ > > > Testing > ------- > > 1. Apply patch > 2. Systemsetting show ok on CJK > > > Thanks, > > Chao Feng > >