----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108277/#review25229 -----------------------------------------------------------
This review has been submitted with commit 99175ed16914d4a1e1028b9dadb4fd01fc29b446 by David Faure to branch KDE/4.10. - Commit Hook On Jan. 8, 2013, 8:40 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108277/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2013, 8:40 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Description > ------- > > Rework fix for bug 279675 so that the new mimetype is used by KRun too. > > When the mimetype has to be refined from the url-filename or > suggested-filename, > it's not enough to show the user, we have to also pass it on to the > application > and to KRun. Otherwise clicking "open with KWrite" can end up not doing > anything, > due to the service->hasMimeType() check in KRun. It also didn't benefit from > the turning of shellscript into text/plain in BrowserRun::handleNonEmbeddable > since the mimetype fixup was done afterwards. > > > This addresses bug 279675. > http://bugs.kde.org/show_bug.cgi?id=279675 > > > Diffs > ----- > > kparts/browseropenorsavequestion.cpp > 3b7ad0bf52137f44c736f7758399e718279f6bd1 > kparts/browserrun.cpp 6de0380a04b58ff72c4cdd89dc18ccbabde9c629 > > Diff: http://git.reviewboard.kde.org/r/108277/diff/ > > > Testing > ------- > > Opening a "foo.sh" attachment on roundcube (which sends > application/octet-stream as mimetype). > It offered "open with kwrite" but choosing that would lead to an open-with > dialog, because the mimetype was still application/octet-stream in KRun. > With this fix, kwrite runs. > > > Thanks, > > David Faure > >
