----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108197/#review25580 -----------------------------------------------------------
the reason for the change was that hitting "enter" too quickly would cause nothing to happen. one had to hit "enter" at just the right moment. it was reverted in 4.9 simply because i could not do the testing needed to verify yes/no if it worked or not. now, i can't seem to replicate the issue, using krunner on a daily basis, that others are seeing with this. perhaps it is a difference in qt version or some such? i'm using 4.8.3 here with the 4.10 branch of kdelibs. - Aaron J. Seigo On Jan. 5, 2013, 11:31 a.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108197/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2013, 11:31 a.m.) > > > Review request for kde-workspace and Aaron J. Seigo. > > > Description > ------- > > Aaron reverted some code in the 4.9 branch but not in the 4.10 branch where > he seemed to not have the bug. Although we all have the bug and thus this > patch reverts the code in the same way he did for 4.9. Should also be fixed > in master because Enter not working makes KRunner useless. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=309787. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=309787 > > > Diffs > ----- > > krunner/interfaces/default/interface.cpp fac1066 > > Diff: http://git.reviewboard.kde.org/r/108197/diff/ > > > Testing > ------- > > Works as expected > > > Thanks, > > Anne-Marie Mahfouf > >
