----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108427/#review25613 -----------------------------------------------------------
Ship it! I would suggest separating the white space changes out into a separate commit, but otherwise this looks fine to me (assuming it compiles). - Ben Cooksley On Jan. 15, 2013, 7:47 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108427/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 7:47 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > Icons in tooltips of System Settings items are hardcoded to 32x32 (for the > title) and 24x24 (for items inside). This fixes it by using Dialog icons > (defaults to 32x32) and toolbar icons (defaults to 22x22) instead. > > (Sorry about the unrelated white-space changes, automagic by Kate, and not a > bad thing imho :P) > > > Diffs > ----- > > systemsettings/app/ToolTips/tooltipmanager.cpp 44fc8ff > > Diff: http://git.reviewboard.kde.org/r/108427/diff/ > > > Testing > ------- > > By default you won't notice any difference at all. But users of MacBook Pro > Retina and similar devices will appreciate. > > > File Attachments > ---------------- > > System Settings with Retina settings > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/15/systemsettingstooltips.png > > > Thanks, > > Kai Uwe Broulik > >
