> On Jan. 16, 2013, 10:10 a.m., Thomas Lübking wrote: > > kcontrol/colors/colorscm.cpp, line 747 > > <http://git.reviewboard.kde.org/r/108433/diff/1/?file=107425#file107425line747> > > > > w/o having checked code it seems the view has a static row height and > > the last kid would by this set the game. > > > > i'd say minHeight should be determined as qMax(minHeight, > > btn->sizeHint().height()) and initialized by the font height (given the > > font is equal for all elements, otherwise needs to be qMax'd in every row > > as well) > > > > ultimately in a second pass set all row heights, while probably even > > setting one would be sufficient
minHeight is calculated by the Varies button which is the biggest element here (font + margin), the font is equal, yes. Also, all rows are getting a minHeight (it's a for..next loop) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108433/#review25637 ----------------------------------------------------------- On Jan. 16, 2013, 1:56 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108433/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 1:56 a.m.) > > > Review request for kde-workspace. > > > Description > ------- > > This makes the row height of color list depend on the height of the "Varies" > button. > > The KColorButtons on the other pages also need fixing but this should be done > in KColorButton in kdelibs rather than hacking in the "Varies" thing there as > well. > > (Not sure if I need to delete that PushButton afterwards) > > > Diffs > ----- > > kcontrol/colors/colorscm.cpp b9b911f > > Diff: http://git.reviewboard.kde.org/r/108433/diff/ > > > Testing > ------- > > Yup, see screenshots. > > > File Attachments > ---------------- > > After with normal fonts > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colornormalsize.png > Before with huge fonts > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png > After with huge fonts > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png > > > Thanks, > > Kai Uwe Broulik > >
