----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108471/#review25808 -----------------------------------------------------------
Makes sense. However I don't like the logic duplication, for future maintainance. Let's extract it. Can you test if this works for you? http://www.davidfaure.fr/2013/kprotocolinfo.diff - David Faure On Jan. 18, 2013, 1:29 p.m., Reza Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108471/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 1:29 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > In krunner if you enter '[email protected]' one of the result will be: > 'Launch with ...' like in screenshot (minus icon). > > My patch will try to search the icon for helper protocol too. > The logic is similar to KProtocolInfo::exec function, > which return icon instead of exec. > > > Diffs > ----- > > kdecore/sycoca/kprotocolinfo.cpp f72049a > > Diff: http://git.reviewboard.kde.org/r/108471/diff/ > > > Testing > ------- > > tested agains krunner in master branch > > > File Attachments > ---------------- > > krunner > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/18/krunnericon.png > > > Thanks, > > Reza Shah > >
