----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108637/#review26798 -----------------------------------------------------------
This review has been submitted with commit f3f6b9c7d533c3c03ceb47b9de753c74c4e082b9 by Albert Astals Cid to branch KDE/4.10. - Commit Hook On Feb. 5, 2013, 11:56 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108637/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 11:56 p.m.) > > > Review request for kdelibs and Laurent Montel. > > > Description > ------- > > Do not connect colorSelected to _k_colorChosen otherwise two bad things > happen: > a) Selecting a color and canceling still changes the color of the color > button (this is KColorButtonTest::testChangeAndCancel that fails without my > change) > b) If you are in Recent Colors there's a crash (bug 313984 because a lot of > bad things happen (this is KColorButtonTest::testRecentColorsPick that > crashes without my change) > > Laurent added > connect(dialog, SIGNAL(colorSelected(QColor)), q, > SLOT(_k_colorChosen())); > to make sure that double click worked, thus i've added > KColorButtonTest::testDoubleClickChange() to prove it still works after my > change > > Comments? > > Developed against master, plan to apply against KDE/4.10 too > > > Diffs > ----- > > kdeui/tests/kcolorbuttontest.cpp PRE-CREATION > kdeui/tests/kcolorbuttontest.h PRE-CREATION > kdeui/tests/CMakeLists.txt 85f12ed > kdeui/colors/kcolorbutton.cpp 786cb9d > > Diff: http://git.reviewboard.kde.org/r/108637/diff/ > > > Testing > ------- > > Okular no longer crashes, the tests pass > > > Thanks, > > Albert Astals Cid > >