----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/#review27081 -----------------------------------------------------------
Cool. Just a bunch of minor things. staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20421> const QString & staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20422> const QString & staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20423> well, const QString & :) staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20429> No space after the ':', qWarning adds one already. staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20424> trailing whitespace (same further down) staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20425> Q_FUNC_INFO not necessary anymore in Qt5. Developers can set QT_MESSAGE_PATTERN to see many things in debug output, including the method name (see kf5 wiki). staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20426> const ref staging/sonnet/src/core/loader.cpp <http://git.reviewboard.kde.org/r/108875/#comment20431> This method could avoid calling languageClients[language] 4 times, by just calling it one and putting the result in a QList &. staging/sonnet/src/plugins/aspell/CMakeLists.txt <http://git.reviewboard.kde.org/r/108875/#comment20427> don't forget to port this too, to add_library( .. MODULE ). staging/sonnet/src/plugins/enchant/CMakeLists.txt <http://git.reviewboard.kde.org/r/108875/#comment20428> you can remove this now, right? - David Faure On Feb. 9, 2013, 5:02 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108875/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2013, 5:02 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Description > ------- > > Port Sonnet to use QPluginLoader instead of KServiceTypeTrader/KPluginLoader. > > > Diffs > ----- > > staging/sonnet/src/core/CMakeLists.txt fcbbbe1 > staging/sonnet/src/core/loader.cpp bd64e2a > staging/sonnet/src/core/loader_p.h 896a8f8 > staging/sonnet/src/plugins/aspell/CMakeLists.txt 2f7c4bd > staging/sonnet/src/plugins/enchant/CMakeLists.txt e3365cf > staging/sonnet/src/plugins/hspell/CMakeLists.txt 9e7bf13 > staging/sonnet/src/plugins/hunspell/CMakeLists.txt 3f8a30c > > Diff: http://git.reviewboard.kde.org/r/108875/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
