----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29173 -----------------------------------------------------------
Looks good, please fix the one issue below and commit. khtml/imload/decoders/gifloader.cpp <http://git.reviewboard.kde.org/r/109478/#comment21779> What's "e" ? an error code? Please rename the variable then, for more readability. - David Faure On March 14, 2013, 8:11 a.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109478/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 8:11 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > This patch makes kdelibs compile with the newest giflib v5, while maintaining > backwards compatibility. > > > Diffs > ----- > > khtml/imload/decoders/gifloader.cpp ebbb749 > > Diff: http://git.reviewboard.kde.org/r/109478/diff/ > > > Testing > ------- > > kdelibs compiles successfully with both giflib v5 and giflib v4 > > > Thanks, > > Raymond Wooninck > >
