----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29781 -----------------------------------------------------------
I like the idea, but I would prefer using @SHARE_INSTALL_PREFIX@ instead of `kde4-config --prefix` (including in the existing line of code). startkde.cmake is already pre-processed to replace such vars with their value, which makes this faster at runtime, and removes a dependency on kde4-config (in preparation for KF5). - David Faure On March 23, 2013, 6:37 p.m., Andreas Hartmetz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109675/ > ----------------------------------------------------------- > > (Updated March 23, 2013, 6:37 p.m.) > > > Review request for kdelibs and Vishesh Handa. > > > Description > ------- > > Planned commit message: > > Make sure that the KDE prefix comes first in XDG_DATA_DIRS. > > I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't > work because the ontologies were too old. Nepomuk loaded ontologies > from /usr/share instead of my KDE prefix /opt/kde4/share, because > /opt/kde4 was the very last entry in the respective search list in > KStandardDirs. The first entries in that search list all came from > XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session > initialization scripts. That is before startkde runs, so startkde > never touched XDG_DATA_DIRS. But it should, and now it does. > > > Diffs > ----- > > startkde.cmake 8361fe0 > > Diff: http://git.reviewboard.kde.org/r/109675/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hartmetz > >
