----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109814/#review30235 -----------------------------------------------------------
Qt 4.8 seems like it was released 1.5 years ago, if we need it for a feature I don't see why we should not increase the requirement - Albert Astals Cid On April 1, 2013, 6:41 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109814/ > ----------------------------------------------------------- > > (Updated April 1, 2013, 6:41 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > http://git.reviewboard.kde.org/r/109784/ requires a Qt 4.8 feature > > Though kdelibs/CMakeLists.txt in 4.10 already has >>set (QT_MIN_VERSION > "4.8.0")<< kde-workspace atm. requires 4.9.4 which does have that requirement. > > So this boils down to the question whether > a) kde-workspace 4.11 (or just git master) on kdelibs 4.9.x is actually a > concern. > b) this would expose any downstream version gap (ie. shipping Qt 4.7 and KDE > 4.9 but you want to compile workspace master) > eg. debian stable has Qt 4.6 (not supported, we already require 4.7) while > testing has 4.8 - so there's no issue. > Ubuntu ships KDE 4.8 on Precise and 4.9 on Quantal (latter alongside Qt 4.8) > > > Diffs > ----- > > CMakeLists.txt 06b779b > > Diff: http://git.reviewboard.kde.org/r/109814/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Lübking > >
