----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109945/#review30857 -----------------------------------------------------------
ksmserver/screenlocker/greeter/greeter.cpp <http://git.reviewboard.kde.org/r/109945/#comment22954> w/o any real insight: why would you return here? looks like for a false PW attempt, but in case you should not leave a wrong password either (could hint length) ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <http://git.reviewboard.kde.org/r/109945/#comment22953> style: ";" (ftr: i don't know which would be more coherent here) - Thomas Lübking On April 10, 2013, 12:33 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109945/ > ----------------------------------------------------------- > > (Updated April 10, 2013, 12:33 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > When you type a password in the locker and press escape, the password > disappears. Now when you press any key, the password reappears and the > pressed key is appended. > > This patch forces the password input to be cleaned on escape keypress. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeter.h a0a1ac3 > ksmserver/screenlocker/greeter/greeter.cpp f5918f9 > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > 3dd9fc0 > > Diff: http://git.reviewboard.kde.org/r/109945/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
