----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109997/#review30996 -----------------------------------------------------------
Regarding the icon tinting, there are bugs filed against this Dolphin behavior, so I am not sure we should replicate it in kdelibs. - Christoph Feck On April 13, 2013, 3:12 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109997/ > ----------------------------------------------------------- > > (Updated April 13, 2013, 3:12 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > As of Dolphin 2.0, Dolphin tints the icons of selected file items by the > palette's highlight color. This patch adapts the KFileItemDelegate rendering > code to mirror this Dolphin behavior for consistency. > > A similar review request was filed against Folder View: > https://git.reviewboard.kde.org/r/109995/ > > > Diffs > ----- > > kio/kio/kfileitemdelegate.cpp 50cc3b6 > > Diff: http://git.reviewboard.kde.org/r/109997/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before/after in KFileDialog > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/tint.png > > > Thanks, > > Eike Hein > >
