> On April 28, 2013, 2:55 p.m., David Faure wrote: > > You were right about the assert, I was off by a "!" in my head. > > > > This patch looks good - except that the comment is buggy :)
Thanks David, there is indeed a typo in the comment ;-) I'll fix that and push the patch to KDE/4.10. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110225/#review31698 ----------------------------------------------------------- On April 28, 2013, 1:28 p.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110225/ > ----------------------------------------------------------- > > (Updated April 28, 2013, 1:28 p.m.) > > > Review request for kdelibs, David Faure and Jekyll Wu. > > > Description > ------- > > The current algorithm that tries to find out what mount point a path belongs > to only checks if the first part of the string matches the mount point. The > problem is that /books is then considered a path inside /book, which is > obviously wrong. > > I propose to fix this by verifying that either the mount point ends with a > '/', or the first char of the path that does not match the mount point is a > '/'. I've factored this check out into a separate function to keep the code > readable. > > Many thanks to Jekyll Wu, who analyzed this bug and found the right place in > the code. > > > This addresses bug 193298. > http://bugs.kde.org/show_bug.cgi?id=193298 > > > Diffs > ----- > > kdecore/io/kmountpoint.cpp aa7a6b1 > > Diff: http://git.reviewboard.kde.org/r/110225/diff/ > > > Testing > ------- > > Works for me. > > > Thanks, > > Frank Reininghaus > >
