----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/ -----------------------------------------------------------
(Updated May 6, 2013, 4:17 p.m.) Review request for KDE Runtime and Harald Sitter. Changes ------- Add links to related reviews. Description (updated) ------- kwalletd has a "Prompt when an application accesses an open wallet" config option. If this option is enabled (it is by default) any such access attempt opens a dialog box asking the user to approve or deny the attempt, and optionally remember the decision for the future. This patch moves the evaluation of this config option into the codepath taken by any app authorization check, in effect turning it into a "Prompt when an application accesses a wallet" setting. The purpose is to allow distributions such as Kubuntu and Netrunner which want to make KWallet mostly invisible during routine operations to disable this setting by default and so avoid the user being prompted to grant applications wallet access rights in more situations. (It should be pointed out that application identity is apparently based on KAboutData information anyway, and so the security of this system is dubious to begin with.) In the interest of keeping the delta between upstream and downstream as small as possible I'd say it makes sense to pick this up. This diff is to be applied after the diff in: https://git.reviewboard.kde.org/r/110328/ A patch rewording the checkbox label in kwalletmanager has been posted for review here: https://git.reviewboard.kde.org/r/110331/ Diffs ----- kwalletd/kwalletd.h e8e74c3 kwalletd/kwalletd.cpp fa9fc11 Diff: http://git.reviewboard.kde.org/r/110330/diff/ Testing ------- Test package for Kubuntu by Harald Sitter, operation verified at runtime. Thanks, Eike Hein
