----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/#review32716 -----------------------------------------------------------
kurifilter-plugins/ikws/searchproviderdlg.cpp <http://git.reviewboard.kde.org/r/110423/#comment24325> I would rather see the button besides the shortcut url edit itself. That way you do not even have to worry about enabling/disabling the button or installing an event filter. You can simply show the icon so the button is small and use the text as a tool tip. kurifilter-plugins/ikws/searchproviderdlg.cpp <http://git.reviewboard.kde.org/r/110423/#comment24324> Why not simply disable the button on a FocusOut event for m_dlg.leQuery ? That way you do not need to install an event filter on all the edits. - Dawit Alemayehu On May 14, 2013, 1:53 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110423/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 1:53 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > This adds a 'Insert query placeholder' button to the add/modify web shortcut > dialog. > -Clicking this button inserts \{@} in the shortcut URL lineEdit. > -The button is only enabled when the shortcut URL lineEdit has focus. > > This makes it easy to add new web shortcuts. Users don't have to remember and > type the query placeholder. > > The eventfilter complicates this patch a lot. But there is no slot to detect > if a lineedit has focus. > We could drop it but it looks messy when the button is always enabled. > I feel the tooltip text can be improved. Any suggestions from a native > English speaker? > > > This addresses bug 146879. > http://bugs.kde.org/show_bug.cgi?id=146879 > > > Diffs > ----- > > kurifilter-plugins/ikws/searchproviderdlg.h e931e11 > kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f > > Diff: http://git.reviewboard.kde.org/r/110423/diff/ > > > Testing > ------- > > Added a new shortcut. > Changed focus to and from different widgets. > Inserted placeholder at the end of the link and in the middle. > Modified a shortcut. > > > File Attachments > ---------------- > > Before - After screenshot > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/before-After.png > > > Thanks, > > Maarten De Meyer > >
