----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110663/#review33215 -----------------------------------------------------------
src/service/Activities.cpp <http://git.reviewboard.kde.org/r/110663/#comment24570> This will break things if kamd has not been shut down by ksmserver. (or if it crashes - it will not restart in the activity it was in beforehands) It could use a separate config variable and check those on start. - Ivan Čukić On May 27, 2013, 10:02 a.m., Simon Persson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110663/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 10:02 a.m.) > > > Review request for kde-workspace and Ivan Čukić. > > > Description > ------- > > Only save state of currently running session when asked to by the session > manager. This will support activities in the "restore manually saved session" > function of the session manager. > > Relies on review https://git.reviewboard.kde.org/r/110662/ > > > Diffs > ----- > > src/service/Activities.cpp 9e09c9f > src/service/Activities_p.h 5f3304d > src/service/jobs/ksmserver/KSMServer.h 7e42e56 > src/service/jobs/ksmserver/KSMServer.cpp 888df1f > > Diff: http://git.reviewboard.kde.org/r/110663/diff/ > > > Testing > ------- > > Tested by running a full kde session compiled from master. Saw that with > "restore previous session" set there was no regression (only change would be > that a power failure or crash of ksmserver would now result in the current > state of running activities not getting saved, hardly critical I would say). > Also saw that "restore manually saved session" now restores activities as > they were when the session was saved. > > > Thanks, > > Simon Persson > >
