----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110799/#review33765 -----------------------------------------------------------
Ship it! konq-plugins/babelfish/plugin_babelfish.desktop <http://git.reviewboard.kde.org/r/110799/#comment24888> Heh, this .desktop file should probably be renamed, then? - David Faure On June 3, 2013, 3:12 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110799/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 3:12 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > Since may 2012 the babelfish service is no longer available, it was moved to > Bing translator > and can't be used no more. > I changed default translator to Google, which is already used by > kdepim/pimcommon/translator/ > > Translating a selection did not work with the old code, so I used the code > from Laurent Montel in the pim translator. > > Btw. pimcommon lib has a nice translation bar, could probably be reused here. > > > Diffs > ----- > > konq-plugins/babelfish/plugin_babelfish.cpp c962f18 > konq-plugins/babelfish/plugin_babelfish.desktop 267ac60 > > Diff: http://git.reviewboard.kde.org/r/110799/diff/ > > > Testing > ------- > > Tested in master + 4.10 in HTML + WebKit view modes > > Result is the same as using translate.google.com direct with text or an url. > > In master in HTML mode a JavaScript Error Warning pops up: > "An error occurred while attempting to run a script on this page. > .... > Type-Error: Attempt to use a non-function object or a value as a function." > > > Thanks, > > Burkhard Lück > >
