----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110824/#review33773 -----------------------------------------------------------
> Regarding the iteration method You can forget about that, i just noted it to not forget that the function could need a general review. It's not in the scope of your efforts. > I was not sure about the 'present windows' case This is be affected if/when plasma (or any other desktop) uses a window per activity (rather than changing the contents of the same desktop window) - Thomas Lübking On June 4, 2013, 9:59 p.m., Stefanos Harhalakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110824/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 9:59 p.m.) > > > Review request for kde-workspace. > > > Description > ------- > > Fix windowAt function to only return windows from current activity. > > > This addresses bug 301447. > http://bugs.kde.org/show_bug.cgi?id=301447 > > > Diffs > ----- > > kwin/effects/desktopgrid/desktopgrid.cpp dc3d82b > > Diff: http://git.reviewboard.kde.org/r/110824/diff/ > > > Testing > ------- > > > Thanks, > > Stefanos Harhalakis > >
