----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/#review33926 -----------------------------------------------------------
Ship it! Few minor comments. kdepasswd/kcm/main.cpp <http://git.reviewboard.kde.org/r/110875/#comment25022> Just QString facePath; kdepasswd/kcm/main.cpp <http://git.reviewboard.kde.org/r/110875/#comment25020> Can this be on the stack? i.e OrgFreedesktopAccountsInterface aInterface("org.freedesktop.Account", "/org/freedesktop/Accounts"); you don't need it beyond the scope of the method (for both) kdepasswd/kcm/main.cpp <http://git.reviewboard.kde.org/r/110875/#comment25021> This might not be right. With an empty pixmap in the image you call uinterface->SetIconFile("") then display an error message "There was an error setting the image: /home/david/.icon" which is a bit misleading. - David Edmundson On June 7, 2013, 9:33 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110875/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 9:33 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > save image file with accountsservice dbus interface. useful in combination > with lightdm greeters; see also: > https://bugzilla.redhat.com/show_bug.cgi?id=950635 > > > Diffs > ----- > > CMakeLists.txt 00de0f92b56599c68bdb2be54d0f01b04b0dda6c > cmake/CMakeLists.txt PRE-CREATION > cmake/modules/PkgConfigGetVar.cmake PRE-CREATION > kdepasswd/kcm/CMakeLists.txt b0600aae0aa8ee33d698cc63a4d3270bf24619e1 > kdepasswd/kcm/main.cpp 5a5248e545cc75433024ae0464ac9f3e05b71900 > > Diff: http://git.reviewboard.kde.org/r/110875/diff/ > > > Testing > ------- > > not tested on systems without accountsservice > > > Thanks, > > Greg T > >
