-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110922/
-----------------------------------------------------------
Review request for Dolphin, KDE Base Apps, David Faure, and Frank Reininghaus.
Description
-------
Change the data in the model before the real renaming is done by
KonqOperations::rename(),
but when the rename operation fails, revert the data changes in the model.
The problem is that DolphinView::slotRoleEditingFinished() changes the data in
the model *before* the actual renaming is performed by KonqOperations/KIO.
But we need this approach for the following cases:
* Immediate feedback from the users point of view (No delay between finish
renaming and DolphinView updates)
* Missing file system/dir lister signals, when there is no file system
notification system (ftp, ssh, ...)
A lot of code in konq_operations.h and konq_operations.cpp is just copy and
paste, to guarantee binary compatibility. (added some TODOs for KF 5.0)
This addresses bug 319119.
http://bugs.kde.org/show_bug.cgi?id=319119
Diffs
-----
dolphin/src/views/dolphinview.h 5a70c55
dolphin/src/views/dolphinview.cpp 9a4b863
lib/konq/konq_operations.h a9aec89
lib/konq/konq_operations.cpp cbb058c
Diff: http://git.reviewboard.kde.org/r/110922/diff/
Testing
-------
Works for me.
Tested with a remote ssh file system on a virtual machine.
Thanks,
Emmanuel Pescosta
