----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review34065 -----------------------------------------------------------
Ship it! Woohoo, much simpler. - David Faure On June 10, 2013, 3:37 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110834/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 3:37 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > This patch, inspired by the issue reported in bug# 317676, attempts to cache > and reuse the original result from the stat call in > KDirListerCache::slotFileDirty. Since that stat call is only needed to > determine whether the "dirty" resource is a file or directory, caching the > result helps us avoid the potential for tons of KDE::stat calls. The stat > will happen if you for example copy or download a large file into a local > folder while that folder is being viewed in a file browsing app such as > dolphin or konqueror. The cached information is removed if the resource being > monitored is deleted or renamed. > > > This addresses bug 317676. > http://bugs.kde.org/show_bug.cgi?id=317676 > > > Diffs > ----- > > kio/kio/kdirlister.cpp a721673 > > Diff: http://git.reviewboard.kde.org/r/110834/diff/ > > > Testing > ------- > > The patch was tested by the bug reporter and it fixed the issue for him. > > > Thanks, > > Dawit Alemayehu > >
