----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34437 -----------------------------------------------------------
While speedup is certainly always great, this sounds dangerous to me: > I am getting an inconsistency. Using the unpatched fast mime detection on a > file like: "test.tar.gz" gets detected as "application-x-compressed-tar" > where the patched > version detects it as "application-gzip". The slow and > detailed mime detection detects the same file as > "application-x-compressed-tar". What should it be? > application-gzip or > application-x-compressed-tar? > Note: This improved detection does expect folders to end with a "/". I have no idea how e.g. KDevelop would react to those changes. In any case I would vote against putting such a fundamental change in behaviour into the soon-to-be-released 4.11 (without a long testing period). I didn't look at the code. - Sven Brauch On June 16, 2013, 4:42 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111050/ > ----------------------------------------------------------- > > (Updated June 16, 2013, 4:42 p.m.) > > > Review request for kdelibs, David Faure and Frank Reininghaus. > > > Description > ------- > > Hi, > > I've recently seen Frank Reininghaus do his best in speeding up the rendering > in dolphin with regards to the app icons. And trying to prevent icon > flickering between "unknown" and the actual icon. > > While reading his posts on the mailing list i was beginning to wonder: "is > fast mime detection actually fast"? While it was certainly faster then "slow" > mime detection, it still didn't really seem fast to me. A small benchmark app > hat ran fast mime detection in /usr/bin took ~40ms to complete. That's for > just 2656 items. > > After quite a bit of profiling i managed to to bring the duration down from > ~40ms to ~3ms sometimes ~4ms. That's well over 10x faster. > Mime detection by extension (like "file.tar.bz") is done as follows: > > file.tar.bz > Loop - find first dot > - "tar.gz" > if that matches a mime type then it's returned if it doesn't then it proceeds > on to the next dot: > - next dot: "gz" > if that matches.. return. > Otherwise it will return the default mime type. > > I am getting an inconsistency. Using the unpatched fast mime detection on a > file like: "test.tar.gz" gets detected as "application-x-compressed-tar" > where the patched version detects it as "application-gzip". The slow and > detailed mime detection detects the same file as > "application-x-compressed-tar". What should it be? application-gzip or > application-x-compressed-tar? > > Note: This improved detection does expect folders to end with a "/". > Otherwise they will be detected as application-octet-stream (the default). > But i think this is common sense to let folders end with a "/". If any apps > that don't do that, they should fix it i suppose. > > Best thing, it's all internal and private api change. No public function is > changed. > > All feedback is welcome! If possible, i would like to put this in KDE 4.11. > > > Diffs > ----- > > kdecore/services/kmimetype.h bc35bcf > kdecore/services/kmimetype.cpp d748523 > kdecore/services/kmimetyperepository.cpp f56f48e > kdecore/services/kmimetyperepository_p.h e1d2389 > > Diff: http://git.reviewboard.kde.org/r/111050/diff/ > > > Testing > ------- > > Tested this using just output comparison between the old version and the new > implementation. It works just fine. > > > Thanks, > > Mark Gaiser > >
