----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103168/#review34862 -----------------------------------------------------------
This review has been submitted with commit 0e934088c5647fe3d56f76fdb28d05c0fdf0f7a4 by David Faure to branch KDE/4.10. - Commit Hook On June 7, 2013, 1:20 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103168/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 1:20 p.m.) > > > Review request for kdelibs, Thomas Braxton and Oswald Buddenhagen. > > > Description > ------- > > KConfig: properly implement revertToDefault(). > > Now it really removes the entry from the local file, instead of copying > the value from the global file ("defaults" file, in internal terminology). > This implements a long-standing TODO, which is now removed from the TODO file. > > And it doesn't mark the KConfig as dirty if there's no local entry, > which makes closing kmail composer windows a LOT faster. > > REVIEW: 103168 > > > Diffs > ----- > > kdecore/config/TODO 158a78adbcd49fafd2863155b42f354a413b0136 > kdecore/config/kconfig.h 51381cab586d44170ee614b0d43b0d333713103d > kdecore/config/kconfig.cpp 048605d052595b3f357c0fac6117e91a3b7be0b3 > kdecore/config/kconfig_p.h 7751242b47abb9a9dd21c0553ee455c356b8ccc4 > kdecore/config/kconfigdata.h e5dd7da5888fbc6523b544de05732a4559c807e1 > kdecore/config/kconfigdata.cpp 8f837fb8eec896c1ceb245bc6854cdfba55cce4b > kdecore/config/kconfiggroup.cpp 9e73eb71480cdd023b232442409ea0c25042072a > kdecore/config/kconfigini.cpp 6e2021c1d79f14862e1ddbe1cccda6fa6e2121f7 > kdecore/tests/kconfigtest.h 3b01c66fd49cda833044dfcb5f2b51c24da7f18b > kdecore/tests/kconfigtest.cpp e5d2e80da0685615a0028ccd7254487664ffc6b0 > > Diff: http://git.reviewboard.kde.org/r/103168/diff/ > > > Testing > ------- > > > Thanks, > > David Faure > >
