----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341/#review35402 -----------------------------------------------------------
Looks like the proper source, but i guess the icon should be rather replaced so that any user of knetattach (eg. a local .desktop file) gets the updated variant. Please attach Nuno to the review as the icons are his domain ;-) - Thomas Lübking On July 1, 2013, 3:12 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111341/ > ----------------------------------------------------------- > > (Updated July 1, 2013, 3:12 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current > icon is from the KDE 3 era and should be updated. Maybe it's also worth > dropping the old icons from the knetattach folder? > > > Diffs > ----- > > knetattach/knetattach.cpp 3d348c1 > knetattach/knetattach.desktop 2684602 > > Diff: http://git.reviewboard.kde.org/r/111341/diff/ > > > Testing > ------- > > Works fine for quite some time on Kubuntu. > > > Thanks, > > Rohan Garg > >
