----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35511 -----------------------------------------------------------
plasma/generic/applets/systemtray/ui/widgetitem.cpp <http://git.reviewboard.kde.org/r/111370/#comment26087> Sorry about the ridiculous ping-pong, but that still isn't right. I should maybe have pointed you to some other file with an example. In any case, this is the usual style: Foo::Foo(QObject *parent) : QObject(parent), m_someVariable(0), m_someOtherVariable("bar") { } - Andreas Hartmetz On July 3, 2013, 11:58 a.m., Jiri Slaby wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111370/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 11:58 a.m.) > > > Review request for kde-workspace and Kai Uwe Broulik. > > > Description > ------- > > A member in WidgetItem is used unitialized. Fix this. > > See https://bugs.kde.org/show_bug.cgi?id=321828 > > > Diffs > ----- > > plasma/generic/applets/systemtray/ui/widgetitem.cpp > 1f922c921c0f3763e8ffeb4466fbffb527fca2f2 > > Diff: http://git.reviewboard.kde.org/r/111370/diff/ > > > Testing > ------- > > > Thanks, > > Jiri Slaby > >
