> On July 5, 2013, 2:23 p.m., David Faure wrote: > > kio/kio/scheduler.cpp, line 766 > > <http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766> > > > > Please don't put this code in scheduler.cpp > > > > I'm trying to properly split core and gui aspects of KIO in frameworks, > > and scheduler is definitely core, while kmessagebox is definitely not. > > > > Please find a way to separate the two.
So how were you planning to separate the core and gui aspects in frameworks? Without this patch KIO::Scheduler will still be linking against gui libraries because of its use of KIO::Slave. Perhaps if I know how you were planning to perform the split, I could follow the same approach to resolve this issue and it would be one less thing you have to deal with. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111335/#review35634 ----------------------------------------------------------- On July 3, 2013, 12:19 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111335/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 12:19 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The attached patch addresses one of the oldest bugs in KIO. Due to the > muti-process nature of KIO, if any of the ioslaves encounter something that > requires user input, the user might end up getting prompted multiple times. > The best example of this is SSL error warnings sent to the client by > kio_http. The patch completely resolves this problem using the same approach > as kpasswdserver, but without the need for an additional kded process. > > > This addresses bugs 154100 and 265228. > http://bugs.kde.org/show_bug.cgi?id=154100 > http://bugs.kde.org/show_bug.cgi?id=265228 > > > Diffs > ----- > > kio/kio/scheduler.h 04edb40 > kio/kio/scheduler.cpp 802f8b8 > kio/kio/scheduler_p.h d68f645 > kio/kio/slaveinterface.h 4bfcec8 > kio/kio/slaveinterface.cpp aa0fc44 > kio/kio/slaveinterface_p.h e31ec5e > > Diff: http://git.reviewboard.kde.org/r/111335/diff/ > > > Testing > ------- > > Visit a site that throws up SSL warnings and causes KIO to show more than one > error dialog. > > > Thanks, > > Dawit Alemayehu > >
